HHH-18858 array fields and static metamodel #9360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ementCollection should be represented with ListAttribute, not SingularAttribute
Member
Contributor
Author
Member
|
Oh, sorry, it's me who got mixed up. Sorry. |
gavinking
approved these changes
Dec 4, 2024
Member
gavinking
left a comment
gavinking
left a comment
There was a problem hiding this comment.
LGTM, can I merge it if the tests succeed?
Contributor
Author
|
Yes, of course. [I'll remove draft status when tests are finished] |
Member
|
Thanks so much @cigaly! By the way, I was trying to contact you on Zulip.... |
Contributor
Author
|
... and you did not found me 'cause I have not been registered. I guess that now you can. |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue HHH-18858
When array property is annotated with one of
@ManyToMany,@OneToMany, or@ElementCollection, field in generated meta model class should be of typejakarta.persistence.metamodel.ListAttribute, currently isjakarta.persistence.metamodel.SingularAttribute.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-18868